Skip to content

Commit

Permalink
cloud-hypervisor: Remove hardcoded value of console
Browse files Browse the repository at this point in the history
We have kernelConsole value already defined but its
not being used as argument. So removing hardcoded value
and using kernelConsole value, which will fix issue console
service crash issue on aarch64.

Signed-off-by: Vunny Sodhi <[email protected]>
  • Loading branch information
vunnyso authored and astro committed Jun 15, 2024
1 parent 02a1fe9 commit b11f000
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/runners/cloud-hypervisor.nix
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ in {
"--serial" "tty"
"--kernel" kernelPath
"--initramfs" initrdPath
"--cmdline" "console=ttyS0 reboot=t panic=-1 ${toString microvmConfig.kernelParams}"
"--cmdline" "${kernelConsole} reboot=t panic=-1 ${toString microvmConfig.kernelParams}"
"--seccomp" "true"
"--memory" memOps
"--platform" "oem_strings=[io.systemd.credential:vmm.notify_socket=vsock-stream:2:8888]"
Expand Down

0 comments on commit b11f000

Please sign in to comment.