Add improved error message for scanner page's upload button #281
Conversation
|
Hi, sorry for the late reply. I'll have a look tomorrow |
| @@ -1001,5 +1001,6 @@ | |||
| "@discardChangesWarning": { | |||
| "description": "Warning message shown when the user tries to close a route without saving the changes." | |||
| }, | |||
| "changelog": "Changelog" | |||
| "changelog": "Changelog", | |||
There was a problem hiding this comment.
Regarding all translations: Did you add the new strings to the .arb files directly or did you create them in crowdin?
There was a problem hiding this comment.
I see. I think it would make more sense to not show a message when the button is disabled due to the current app state (not connectivity state), i.e. don't show a snackbar at all. Otherwise we would need a reason why the button is disabled. It should be evident to the user that the upload button is disabled because there is nothing to upload. So maybe remove the translations and the disabledReason property. Only show the "You're offline" snackbar when the user is offline and therefore the button is disabled. If disabled is true but the user is online, don't show anything.
|
I created them directly.
Oh cool, responding to the email doesn't respond to the review comment
Am 19. Oktober 2023 13:44:49 MESZ schrieb Anton Stubenbord ***@***.***>:
…
@astubenbord commented on this pull request.
> @@ -1001,5 +1001,6 @@
***@***.***": {
"description": "Warning message shown when the user tries to close a route without saving the changes."
},
- "changelog": "Changelog"
+ "changelog": "Changelog",
Regarding all translations: Did you add the new strings to the .arb files directly or did you create them in crowdin?
--
Reply to this email directly or view it on GitHub:
#281 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Fixes #280
There's already a
noDocumentsScannedtranslation key. But since ones an error and the other a hint I prefer having different keys for that.