Enhance filename and display name synchronization on document upload #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add regex pattern to replace umlauts and accented characters by their corresponding simple character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading files, you can already synchronize the file name with the display name. The pattern '[\W_]' is currently used to replace all non-word characters with '_'. However, this procedure also replaces umlauts or other letters with accents. I have therefore extended the previous process so that umlauts and letters with accents are replaced accordingly. For the replacement rule for letters with accents, I have relied on 'source internet', as I do not speak all languages.
What's not particularly nice about the current solution is that 'toLowerCase()' and the two RegEx run over the filename a total of three times. If anyone has a better solution, please let me know :)