Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Use gridplot' suggestion for PairPlot #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AllinCottrell
Copy link
Collaborator

Description of changes

  • Use of gridplot means that all the graphics file formats supported by gretl can be used.
  • It also means that usage via gretlcli in "display" mode works.
  • A title option is added, drawing on relatively new functionality in gridplot.
  • In case the user's specification calls for just a single plot, no "multiplot" is created.
  • The graphical interface is enhanced, with more options.

@atecon atecon mentioned this pull request Jun 9, 2024
@atecon
Copy link
Owner

atecon commented Jun 9, 2024

Hi Allin,
thank you for your effort to contribute to the package. It took me a while to understand your large PR. This is why I've created another branch on which I implemented step-by-step your suggestions in order to understand things.

My new PR based on your suggestions can be found here:
#9

This new branch includes at least 99 % of your code changes. Only a few LOCs of existing code (mainly formatting) I did not change as you'll see.

I've added you as a co-author, too.

Once you've checked the other branch, we can upload the new package version.

I would suggest to close this PR #8 for now if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants