Arc 968 view repos addons #2357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make searchbar not case sensitive re-render repo list on search clear add debouncing to search add FINISHED option in filter
krazziekay
previously approved these changes
Aug 21, 2023
static/js/jira-connected-repos.js
Outdated
| $('#repo-search').on('input', function() { | ||
| // re-render the original list after clearing the search bar | ||
| if($(this).val().length === 0) { | ||
| loadRepos(1) |
There was a problem hiding this comment.
\nit
Suggested change
| loadRepos(1) | |
| loadRepos(1); |
static/js/jira-connected-repos.js
Outdated
| @@ -1,4 +1,6 @@ | |||
| $(document).ready(() => { | |||
| // to get the focus back on seach bar after comp reload | |||
There was a problem hiding this comment.
\nit Typo
Suggested change
| // to get the focus back on seach bar after comp reload | |
| // to get the focus back on search bar after comp reload |
| @@ -54,7 +54,7 @@ export const JiraGetConnectedRepos = async ( | |||
| [Op.and]: [ | |||
| { | |||
| repoName: { | |||
| [Op.like]: `%${repoName}%` | |||
There was a problem hiding this comment.
Hi while you are here, can you also have a look at is this replacement vulnerable for the SQL injection attack? I suspect we should use something else instead of [Op.like]: `...${}...`
| let repoSearchTimeoutId; | ||
| $('#repo-search').on('input', function() { | ||
| // re-render the original list after clearing the search bar | ||
| if($(this).val().length === 0) { |
There was a problem hiding this comment.
If we don't have this block
if($(this).val().length === 0) {
loadRepos(1);
}
The function will still re-render the original list after clearing the search bar after 500ms? So above block is just to make it quicker on empty state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
add-ons and fixes:
Screen.Recording.2023-08-21.at.8.36.20.pm.mov
Why
Make the feature better
Added feature flags
NA
Affected issues
NA
How has this been tested?
Jest unit test cases and locally via atlas tunnel
Whats Next?