Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PKCE-related messaging #789

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Update PKCE-related messaging #789

merged 2 commits into from
Aug 11, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Aug 11, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Recently there have been some changes in Manage, and now the Token Endpoint Authentication Method setting no longer shows up for mobile apps (because for this kind of app it must be None). Whereas for regular web apps it's been moved to another tab:

Screenshot 2023-08-11 at 1 55 22 PM

Since it was possible (before this change) to set it to an invalid value for mobile apps, we had to point this out in the README and error messages. Now that this setting is no longer available for mobile apps, this PR reworks the respective messaging.

@Widcket Widcket added documentation This adds, fixes or improves documentation review:tiny Tiny review labels Aug 11, 2023
@Widcket Widcket requested a review from a team as a code owner August 11, 2023 13:04
@Widcket Widcket enabled auto-merge (squash) August 11, 2023 13:18
@Widcket Widcket merged commit 47354dc into master Aug 11, 2023
4 checks passed
@Widcket Widcket deleted the chore/PKCE-error-messaging branch August 11, 2023 13:21
@Widcket Widcket mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This adds, fixes or improves documentation review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants