docs/readme: grammar and wording update #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the English was a bit off in the readme. Updated a few pieces of it.
| @@ -72,7 +72,7 @@ cargo add leaf | |||
| [rust_getting_started]: https://doc.rust-lang.org/book/getting-started.html | |||
| [cargo-edit]: https://github.com/killercup/cargo-edit | |||
|
|
|||
| If you are on a machine that doesn't have support for CUDA or OpenCL you | |||
| If you're on a machine that doesn't have support for CUDA or OpenCL you | |||
There was a problem hiding this comment.
I prefer the more formal "you are" without a contraction.
|
@Bradley-Cooley Thanks! 👍 I made a few comments which I'd like to discuss before merging, the rest looks good. :) |
Readme readability and grammar update based on previous commit's comments
|
@Bradley-Cooley Looks good now! Could you please squash the commits, and I will merge. |
|
☔ The latest upstream changes (presumably #84) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the English was a bit off in the readme. Updated a few pieces of it.