Propagate job cancellation to CodeDeploy #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib42ea1acc853aed054906e9f0b8d110e0b4511df
|
|
||
| this.logger.println("User cancelling CodeDeploy job"); | ||
| try { | ||
| this.logger.println(stopDeployment(aws, deploymentId)); |
There was a problem hiding this comment.
deploymentId might be null here, we should handle that case.
amoebaOfDoom
changed the title
|
|
||
| this.logger.println("Stopping deployment " + deploymentId); | ||
|
|
||
| StopDeploymentResult stopDeploymentResult = aws.codedeploy.stopDeployment( |
There was a problem hiding this comment.
Stopping a deployment might not be immediate. We might want to wait for the deployment to actually stop before continuing.
Change-Id: I458cc1157eb13b9834ff2620dea65f4313358555
Change-Id: I96512f857c41ae4e9814d6b37b85c672dd809a2e
|
Would love to see this so we don't have to give people access to CodeDeploy in the console. |
|
Hi, |
|
Sorry I haven't had time to make the above changes yet. Will try to get to it soon unless anyone else wants to handle. |
|
Will this be merged/Fixed. Currently if you cancel jenkins plan, the deploy still happens with empty deploy folder, which causes unwanted codedeploy trigger on AWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have tested this and it works. Cancelling the job within Jenkins successfully sends a stop to the CodeDeploy Deployment.