fixing bad calculation in spread factor

bancorprotocol · Dec 3, 2023 · f1f34e3 · f1f34e3
1 parent 27d8e30
commit f1f34e3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "@bancor/carbon-sdk",
   "type": "module",
   "source": "src/index.ts",
-  "version": "0.0.87-DEV",
+  "version": "0.0.88-DEV",
   "description": "The SDK is a READ-ONLY tool, intended to facilitate working with Carbon contracts. It's a convenient wrapper around our matching algorithm, allowing programs and users get a ready to use transaction data that will allow them to manage strategies and fulfill trades",
   "main": "dist/index.js",
   "module": "dist/index.js",

diff --git a/src/strategy-management/utils.ts b/src/strategy-management/utils.ts
@@ -324,7 +324,7 @@ export function calculateOverlappingPriceRanges(
   sellPriceLow: Decimal;
   sellPriceMarginal: Decimal;
 } {
-  const spreadFactor = spreadPercentage.plus(1);
+  const spreadFactor = spreadPercentage.div(100).plus(1);
   const buyPriceHigh = sellPriceHigh.div(spreadFactor);
   const sellPriceLow = buyPriceLow.mul(spreadFactor);
 

diff --git a/tests/toolkit.spec.ts b/tests/toolkit.spec.ts
@@ -106,7 +106,7 @@ describe('Toolkit', () => {
         '1500',
         '2000',
         '1845',
-        '0.01'
+        '1'
       );
       expect(result).to.deep.equal({
         buyPriceHigh: '1980.198019801980198019',
@@ -122,7 +122,7 @@ describe('Toolkit', () => {
         '1500',
         '2000',
         '1845',
-        '0.01',
+        '1',
         '100'
       );
       expect(result).to.equal('0.024939801923642185');
@@ -134,7 +134,7 @@ describe('Toolkit', () => {
         '1500',
         '2000',
         '1845',
-        '0.01',
+        '1',
         '0.024939801923642185'
       );
       expect(result).to.equal('100.999999');

diff --git a/tests/utils.spec.ts b/tests/utils.spec.ts
@@ -26,7 +26,7 @@ describe('utils', () => {
         buyPriceLow: new Decimal('1500'),
         sellPriceHigh: new Decimal('2000'),
         marketPrice: new Decimal('1845'),
-        spreadPercentage: new Decimal('0.01'),
+        spreadPercentage: new Decimal('1'),
         buyBudget: new Decimal('100'),
         buyPriceHigh: new Decimal(
           '1980.19801980198019801980198019801980198019801980198019801980198019801980198019801980198019801980198'