sklearn compat

basaks · Aug 15, 2023 · a9a6966 · a9a6966
1 parent 535e4cb
commit a9a6966
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/uncoverml/optimise/models.py b/uncoverml/optimise/models.py
@@ -623,7 +623,7 @@ def __init__(self, target_transform='identity',
         self.target_transform = target_transform
         # loss = 'quantile'  # use quantile loss for median
         # alpha = 0.5  # median
-        self.median_quantile_params ={'objective': 'quantile', "metric": "quantile", 'alpha': 0.5}
+        self.median_quantile_params ={'objective': 'quantile', "metric": "quantile", 'alpha': alpha}
         self.upper_quantile_params = {'objective': 'quantile', "metric": "quantile", 'alpha': upper_alpha}
         self.lower_quantile_params = {'objective': 'quantile', "metric": "quantile", 'alpha': lower_alpha}
 
@@ -639,6 +639,7 @@ def __init__(self, target_transform='identity',
             **kwargs,
             **self.lower_quantile_params
         )
+        self.alpha = alpha
         self.upper_alpha = upper_alpha
         self.lower_alpha = lower_alpha
 

diff --git a/uncoverml/validate.py b/uncoverml/validate.py
@@ -423,7 +423,6 @@ def local_crossval(x_all, targets_all: targ.Targets, config: Config):
         return
 
     log.info("Validating with {} folds".format(config.folds))
-    print(config.algorithm_args)
     model = modelmaps[config.algorithm](**config.algorithm_args)
     classification = hasattr(model, 'predict_proba')
     groups = targets_all.groups