Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize pasting files over pasting HTML content #1148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prioritize pasting files over pasting HTML content #1148

wants to merge 2 commits into from

Commits on May 1, 2024

  1. Prioritize pasting files over pasting HTML content 

    When right clicking and pasting an image the dataTransfer object
contains a file and text/html. If we paste the HTML content, the result
is often a broken image. This change prioritizes pasting the file over
pasting the HTML content.

The gotcha is that when pasting text from MS Word, the dataTransfer object
contains a File with a screenshot of the text and text/html with the
actual text. We need to check if the paste is from MS Word and if so,
we should paste the text instead of the screenshot.
    @afcapel
    afcapel committed May 1, 2024
    Configuration menu
    Copy the full SHA
    39d059b View commit details
    Browse the repository at this point in the history

  2. Prevent duplicate file pastes 

    This change prevents duplicate file pastes by checking if the paste event
is a file paste before handling it. This is necessary because Safari
doesn't support `beforeinput.insertFromPaste` for files, so we are handling
file pastes in the paste event handler too.

We need to check in the `beforeinput.insertFromPaste` event handler if the
event will be also handled by the paste event handler, to avoid duplicate
file pastes.
    @afcapel
    afcapel committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2651ea1 View commit details
    Browse the repository at this point in the history