Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version kotlinc plugins by major version to handle API changes. #1011

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Version kotlinc plugins by major version to handle API changes. #1011

wants to merge 9 commits into from

Commits on Aug 13, 2023

  1. Allow bootstrap to use different versions of kotlinc.

    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    a5dcc72 View commit details
    Browse the repository at this point in the history

  2. Move kotlinc_version and ksp_version to versions 

    Allows reuse when defining kotlinc versions. Supporting multiple plugin apis will require supporting multiple kotlincs.
    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    afb9629 View commit details
    Browse the repository at this point in the history

  3. Create KOTLINC_INDEX, major version to kotlinc metadata 

    Managing multiple kotlinc version increases toil. To simplify things, introduce a centralized list of the support versions of kotlinc. Success for this is predicated on the plugin api remaining stable on point releases, which is anecdotally true.
    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    1977ce4 View commit details
    Browse the repository at this point in the history

  4. Split plugin compilation by major kotlinc version. 

    This provides a separate plugin for each major kotlinc release. Still requires wiring into the toolchain system (follow up PR), but simplifies using older versions of kotlin with less effort.
    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    c53234a View commit details
    Browse the repository at this point in the history

  5. Fix unused

    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    d6ccef2 View commit details
    Browse the repository at this point in the history

  6. Fix broken doc generation 

    Current stardoc cannot seem to handle dynamic key in dictionary comprehensions. The simple solution is to separate the KOTLINC_INDEX from the compiler repository definition. Has the added benefit of keeping development logic from production logic.
    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    67734a7 View commit details
    Browse the repository at this point in the history

  7. ktlint on the plugins. 

    This was apparently skipped on previous passes.
    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    a6a96ee View commit details
    Browse the repository at this point in the history

  8. Update docs with new verisons utility function.

    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    20b6462 View commit details
    Browse the repository at this point in the history

  9. Fix package supression annotation

    @restingbull
    restingbull committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    d1691fe View commit details
    Browse the repository at this point in the history