Skip to content
This repository has been archived by the owner on Mar 20, 2020. It is now read-only.

dev: update dependencies #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

dev: update dependencies #30

wants to merge 3 commits into from

Conversation

p1tt1
Copy link
Contributor

@p1tt1 p1tt1 commented Jul 12, 2019

close #19

@p1tt1
Copy link
Contributor Author

p1tt1 commented Jul 19, 2019

commit aef39c0

Proposal to clean up the app structure and unify the configuration

@benwr
Copy link
Owner

benwr commented Aug 6, 2019

I'm finally back from traveling so I should have a chance to look at this in detail soon - thanks for the PR!

Copy link
Owner

@benwr benwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good; thanks for the PR and especially for updating the readme!

@@ -261,24 +259,31 @@ def __getitem__(self, deckname):
def field_to_html(field):
"""Need to extract the math in brackets so that it doesn't get markdowned.
If math is separated with dollar sign it is converted to brackets."""
if CONFIG['dollar']:
if CONFIG['math_mode'] is 'dollars':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want ==, not is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... coffeescript sneaks in ;-) I've pushed a fix



return misaka.html(field, extensions=("fenced-code", "math"))
if CONFIG['misaka_renderer'] is 'HighlighterRenderer':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should be ==

#
# add highlight css rules
#
if CONFIG['misaka_renderer'] is 'HighlighterRenderer':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should be ==

@p1tt1
Copy link
Contributor Author

p1tt1 commented Oct 9, 2019

Did you notice my change commit? ;-)

@benwr
Copy link
Owner

benwr commented Oct 9, 2019

Sorry! I've been super busy again the last month or so; I'll try to merge this tonight (although my power and internet might be shut off so no promises)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyYAML warnings are annoying
2 participants