Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(SPV-599): change default HashSalt #71

Merged
merged 1 commit into from
May 17, 2024
Merged

chore(SPV-599): change default HashSalt #71

merged 1 commit into from
May 17, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Description

  • Changed default HashSalt

!!! WARNING: this change is backward incompatible

@pawellewandowski98 pawellewandowski98 self-assigned this May 14, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner May 14, 2024 11:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

dorzepowski
dorzepowski approved these changes May 15, 2024
View reviewed changes
config/viper.go Show resolved Hide resolved
@chris-4chain chris-4chain added the tested PR was tested by a team member label May 17, 2024
@pawellewandowski98 pawellewandowski98 added the enhancement New feature or request label May 17, 2024
@pawellewandowski98 pawellewandowski98 merged commit 744af38 into main May 17, 2024
6 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-599-change-default-HashSalt branch May 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorzepowski dorzepowski dorzepowski approved these changes

@Nazarii-4chain Nazarii-4chain Nazarii-4chain approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
enhancement New feature or request tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pawellewandowski98 @dorzepowski @Nazarii-4chain @chris-4chain