Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring(spv-795) adjusted constructors to match new backend #72

Merged
merged 6 commits into from
May 21, 2024
Merged

refactoring(spv-795) adjusted constructors to match new backend #72

merged 6 commits into from
May 21, 2024

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented May 20, 2024

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @wregulski resulted in success.

@ac4ch ac4ch marked this pull request as ready for review May 20, 2024 04:36
@ac4ch ac4ch requested a review from a team as a code owner May 20, 2024 04:36
chris-4chain
chris-4chain reviewed May 20, 2024
View reviewed changes
go.mod Show resolved Hide resolved
transports/http/endpoints/status/endpoints.go Show resolved Hide resolved
transports/spvwallet/client_factory_adapter.go Outdated Show resolved Hide resolved
transports/spvwallet/client_factory_adapter.go Outdated Show resolved Hide resolved
@ac4ch ac4ch requested a review from chris-4chain May 20, 2024 09:40
@wregulski wregulski added the tested PR was tested by a team member label May 20, 2024
@chris-4chain chris-4chain merged commit 37c879a into main May 21, 2024
6 checks passed
@chris-4chain chris-4chain deleted the spv-795-adjust-codebase-to-refactorized-go-client branch May 21, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ac4ch @chris-4chain @wregulski @augustync