Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPV-807: shared config #74

Merged
merged 5 commits into from
May 28, 2024
Merged

SPV-807: shared config #74

merged 5 commits into from
May 28, 2024

Conversation

Nazarii-4chain
Copy link
Contributor

@Nazarii-4chain Nazarii-4chain commented May 24, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

go client shared config PR should be merged before

@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner May 24, 2024 08:48
@Nazarii-4chain Nazarii-4chain self-assigned this May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 24, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@Nazarii-4chain Nazarii-4chain changed the title PR in js client should be merged before SPV-807: shared config May 24, 2024
@chris-4chain
Copy link
Contributor

It works👍
But, you have to bump version of go-client before merging.

@chris-4chain chris-4chain added the tested PR was tested by a team member label May 28, 2024
@Nazarii-4chain Nazarii-4chain merged commit 8c2f20f into main May 28, 2024
6 checks passed
@Nazarii-4chain Nazarii-4chain deleted the SPV-807/sharedConfig branch May 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees

@Nazarii-4chain Nazarii-4chain

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nazarii-4chain @chris-4chain