Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build for ghc 9.8.1 (#386) #387

Merged
merged 4 commits into from
Feb 9, 2024
Merged

fix build for ghc 9.8.1 (#386) #387

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2881684
fix build for ghc 9.8.1 (#386)
Jan 30, 2024
be874dc
add information to changelog, fix some formatting and versioning (#386)
Jan 30, 2024
63b1cac
move info in changelog to a different section, add ghc 9.8.1 to githu…
Feb 9, 2024
0f6ff52
Apply suggestions from code review
parsonsmatt Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
- [#378](https://github.com/bitemyapp/esqueleto/pull/378)
- `ToMaybe` instances are now derived for records so you can now left
join them in queries
- @arguri
- [#387](https://github.com/bitemyapp/esqueleto/pull/387)
- Fix build for ghc 9.8.1 / template-haskell 2.18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this into it's own section of the changelog for this version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I got that numbering right.


3.5.10.3
========
Expand Down
2 changes: 1 addition & 1 deletion esqueleto.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ cabal-version: 1.12

name: esqueleto

version: 3.5.11.1
version: 3.5.11.2
synopsis: Type-safe EDSL for SQL queries on persistent backends.
description: @esqueleto@ is a bare bones, type-safe EDSL for SQL queries that works with unmodified @persistent@ SQL backends. Its language closely resembles SQL, so you don't have to learn new concepts, just new syntax, and it's fairly easy to predict the generated SQL and optimize it for your backend. Most kinds of errors committed when writing SQL are caught as compile-time errors---although it is possible to write type-checked @esqueleto@ queries that fail at runtime.
.
Expand Down
4 changes: 3 additions & 1 deletion src/Database/Esqueleto/Record.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ data RecordInfo = RecordInfo
-- cause problems, but it's easy to pass around so might as well.
constraints :: Cxt
, -- | The original record's type-variable-binders.
#if MIN_VERSION_template_haskell(2,17,0)
#if MIN_VERSION_template_haskell(2,21,0)
typeVarBinders :: [TyVarBndr BndrVis]
#elif MIN_VERSION_template_haskell(2,17,0)
arguri marked this conversation as resolved.
Show resolved Hide resolved
typeVarBinders :: [TyVarBndr ()]
#else
typeVarBinders :: [TyVarBndr]
Expand Down
Loading