[PM-8844] Families sponsorship line items bug #4440
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tripe subscription when the sponsorship isn't in the database
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4440 +/- ##
==========================================
- Coverage 40.90% 40.90% -0.01%
==========================================
Files 1260 1260
Lines 60103 60104 +1
Branches 5488 5488
==========================================
Hits 24586 24586
- Misses 34382 34383 +1
Partials 1135 1135 ☔ View full report in Codecov by Sentry. |
amorask-bitwarden
approved these changes
Jun 28, 2024
|
No New Or Fixed Issues Found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8844
📔 Objective
This PR addresses an edge case where an organization sponsorship's free Stripe price ID wasn't being removed from the corresponding Stripe subscription when cancelling the organization's sponsorship. This was resulting in Stripe subscriptions with both a free Families price, and the standard $40 Families price.
This PR addresses this by null coalescing the Stripe Plan ID to the expected value found in the
StaticStore.Also, moved the sponsorship update object to the billing namespace.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes