Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-402: Complete Missing Fields in Block Header to Generate Signature #2502

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented May 31, 2024

Description

BEP-402: Complete Missing Fields in Block Header to Generate Signature

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

galaio
galaio previously approved these changes Jun 5, 2024
@zzzckck
Copy link
Collaborator

zzzckck commented Jun 18, 2024

need a BEP for this PR.

@buddh0 buddh0 changed the title core/types: fix SealHash for Header BEP-402: Complete Missing Fields in Block Header to Generate Signature Jul 2, 2024
Copy link
Contributor

@MatusKysel MatusKysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not merge until the BEP-402 is fully accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants