chore: fix system account issue and hertz storage patch issue on testnet #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jul 9, 2024
crates/bsc/evm/src/patch_hertz.rs
Outdated
| ]; | ||
| if let Some(patch) = MAINNET_PATCHES_BEFORE_TX.iter().find(|patch| { | ||
| patch.block_hash == header.hash_slow() && | ||
| patch.tx_hash == transaction.recalculate_hash() |
There was a problem hiding this comment.
I think tx_hash is good enough, it is ok to have block hash here to double ensure.
I just think it is not efficient to iterate the array for each transaction, what about put the patch tx into a map instead of an array?
unclezoro
reviewed
Jul 9, 2024
unclezoro
reviewed
Jul 9, 2024
unclezoro
reviewed
Jul 9, 2024
unclezoro
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to fix two sync issues
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts