Changes to DTDL for Haystack compliance and missing properties (Issue #4) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated AirHandlingUnit.json, added HeatingMethod and Cooling Method. Updated VariableAirVolume.json, Added Heating and Cooling Method Updated [Foundation Space] Zone.json, AddedSpace Types and alphabetized enumValues. Updated Building.json, removed SpaceTypes schemas, added BuildingTypes schemas, Added PostalCode, GeoLocation, BuildingTypes, and Area. Updated DigitalTwin.json, Deleted location. Updated DataPoint.json, added DataPoint:MeasurementTypes, added PointTypes:Types. Added AreaValue.json Signed-off-by: David Adams <[email protected]>
Signed-off-by: David Adams <[email protected]>
|
This is realted to Isse #4 but I did not know how to attach it to the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated AirHandlingUnit.json, Added HeatingMethod and Cooling Method. Change made to have Haystack equivalent for AHUs.
Updated VariableAirVolume.json, Added Heating and Cooling Method. Change made to have Haystack equivalent for VAVs.
Updated [Foundation Space] Zone.json, Added Space Types and alphabetized enumValues. Change made to have 'Space' types to describe spaces rather than having 'Building' types describe spaces.
Updated Building.json, Removed SpaceTypes schemas, added BuildingTypes schemas, Added PostalCode, GeoLocation, BuildingTypes, and Area. Edits made in conjunction with Zone.json to seprate 'Space' and 'Building' Types.
Updated DigitalTwin.json, Removed location. This was to prevent the GeoLocation being on every digital twin where it may not apply. Location should be part of the twins which it applies to and not as a global parameter.
Updated DataPoint.json, Added DataPoint:MeasurementTypes, added PointTypes:Types. Change made to add Haystack equivalent Measurement and Point Types.
Added AreaValue.json, Added to allow area to be used for buildings. In the future area could be added for spaces, zones, and/or floors. This is up for discussion.
Updated NOTICE, added David Adams