Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump to [email protected] / [email protected] #910

Merged
merged 1 commit into from
May 30, 2024
Merged

deps: bump to [email protected] / [email protected] #910

merged 1 commit into from
May 30, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented May 29, 2024 •
edited
Loading

Improves clear.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 29, 2024
@nikku nikku marked this pull request as draft May 29, 2024 20:01
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 29, 2024
@nikku
Copy link
Member Author

nikku commented May 29, 2024 •
edited
Loading

As it turns out using Element.replaceChildren, a modern API, did not yield expected performance gains (bumping to [email protected] / [email protected]). In fact the implementation was slightly slower (both reproduced through full suite tests, and local spacetool tests).

Reverted the change with follow-up utility library releases ([email protected] / [email protected]).

@nikku nikku mentioned this pull request May 29, 2024
Merged
@nikku
deps: bump to [email protected] / [email protected]
4b920a7 
Slightly improves `clear`, a heavily used utility.
@nikku nikku marked this pull request as ready for review May 29, 2024 21:18
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 29, 2024
@nikku nikku requested review from a team, philippfromme and marstamm and removed request for a team May 29, 2024 21:18
@nikku nikku mentioned this pull request May 30, 2024
Open
10 tasks
@nikku nikku merged commit 5053f8b into develop May 30, 2024
12 checks passed
@nikku nikku deleted the bump-html-utils branch May 30, 2024 08:33
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm marstamm approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikku @marstamm