Do not update context pad visibility on element.marker.update if element is not target
#912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we should not mix ES5 and >ES5 within a single file
nikku
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated https://camunda-modeling.sentry.io/share/issue/d4edab8eb6044c74b7c933158b06a69a/ which happens when reacting to
element.marker.updatewhich callscanvas.hasMarkerfor each of the current targets. In some cases that I couldn't reproduce it seems like at least one of the targets has been deleted at the time of callingcanvas.hasMarkerwhich leads to aA DOM element reference is requiredsince there is no graphical element anymore. While I couldn't reproduce the issue I changed the implementation so context pad visibility is updated onelement.marker.updateonly if the element is a target. This might or might not fix the issue. We'll have to keep an eye on the Sentry issue.