Search improvements

[philippfromme]

Improves search by

• treating search as truly intermediate (root element, selection and viewbox reset on escape without click or enter)
• aligning styles with other popups
• simplifying selection visuals when "pre-selecting" elements before selecting (click or enter)
  • simply use existing outline
  • don't show context pad during pre-select

Related to bpmn-io/bpmn-js#2187

[nikku]

Why do we remove the ability to customize here?

[barmac]

Also, let's keep using semantic html. <strong> for important stuff, <em> for emphasis.

[philippfromme]

I can revert the CSS class removal.

For <b> vs <strong> I'd disagree based on what I read.

The element is for content that is of greater importance, while the element is used to draw attention to text without indicating that it's more important.

I'd say we only want the styling, not the importance.

Each element is meant to be used in certain types of scenarios, and if you want to bold text for decoration, you should instead actually use the CSS font-weight property.

So you could even argue we don't want to use tags at all.

[philippfromme]

In terms of a11y, <strong> matters to screen readers while <b> doesn't which is what I'd expect in that case. I wouldn't expect the screen reader to focus on specific parts of the results.

[nikku]

👍 for "just for decoration.

[barmac]

I like how the tag meaning was changed from "<b>oldface" to "<b>ring attention". I'm ok with leaving it as is.

[nikku]

Heads-up: I reviewed this but somehow the remarks were lost. Going to repeat, once back from FTO.