Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign correct role attribute in popup menu item #918

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Jun 21, 2024

Related camunda/camunda-modeler#4383

Proposed Changes

This removes incorrect aria-role attribute from the popup menu item. Note that the <li> element has an implicit role of listitem and a role=button element as a direct child of a list is not allowed.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac
Copy link
Member Author

barmac commented Jun 21, 2024

I removed the role attribute to keep the changes as minimal as possible. aria-role was already incorrect, so there are no changes in the a11y tree with this PR.

@barmac barmac requested a review from nikku June 21, 2024 13:26
@barmac barmac changed the base branch from develop to main June 21, 2024 14:09
@barmac barmac merged commit 774daa5 into main Jun 21, 2024
12 checks passed
@barmac barmac deleted the fix-popupmenu-item-role branch June 21, 2024 14:11
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants