Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use bpmn-js-element-templates from npm #14

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

barmac
Copy link
Member

@barmac barmac commented Jan 23, 2024

No description provided.

@barmac
Copy link
Member Author

barmac commented Jan 23, 2024

This doesn't work yet, because the bundled bpmn-js-element-templates package executes browser code at import.

@barmac barmac requested review from a team, philippfromme, marstamm and nikku and removed request for a team January 25, 2024 07:56
@barmac
Copy link
Member Author

barmac commented Jan 25, 2024

Ready for review!

@barmac barmac marked this pull request as ready for review January 25, 2024 07:56
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 25, 2024
@nikku
Copy link
Member

nikku commented Jan 25, 2024

Great stuff. The way it's meant to be played ™️

@barmac barmac merged commit d05e737 into main Jan 25, 2024
4 checks passed
@barmac barmac deleted the move-away-from-vendor branch January 25, 2024 08:41
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants