Await SSH tunnel init using docker exec + exit code #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows docker-push-ssh to be called inside of a docker container and check the tunnel status through docker inversion of control (by mounting the docker socket in the calling container).
|
Please rebase this on master. @Apelsin |
brthor
reviewed
Mar 28, 2020
| continue | ||
|
|
||
| if response.getcode() == 200: | ||
| sshCheckCommandResult = Command("docker", [ |
There was a problem hiding this comment.
Does wget have a default timeout? Is it possible to match the 5 second timeout as was the previous behavior?
jonashaag
added a commit
to jonashaag/docker-push-ssh
that referenced
this pull request
Sep 7, 2020
Closed
samsonjs
added a commit
to samsonjs/docker-push-ssh
that referenced
this pull request
Jan 15, 2022
This change is from a different pull-request that was never finished. It adds a 5-second timeout to the wget command as requested in that PR. brthor#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for the SSH tunnel to be ready should take place in the docker-push-ssh-tunnel container and not the host. This fixes issues where the calling container is unable to reach the registry but the tunnel container is, because the tunnel is established through that container.