V2: Improve plugin option import_extension #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin option
import_extensionneeds to be specified with a leading dot, for exampleimport_extension=.js, while the optiontargetdoes not.This PR changes the behavior to accept both
jsand.jsfor backwards compatibility, and updates documentation and examples to usejs.With this change, arbitrary values for
import_extensionare no longer accepted and raise an error in the plugin. I can't think of a use case for values other than the acceptednone,js, andts, but it should be trivial to add support for other values later if necessary.