Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add webvtt export #67

Merged
merged 1 commit into from
Apr 26, 2023
Merged

✨ Add webvtt export #67

merged 1 commit into from
Apr 26, 2023

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Apr 17, 2023

No description provided.

@pajowu pajowu marked this pull request as ready for review April 17, 2023 14:11
@pajowu pajowu requested review from anuejn, phlmn and rroohhh April 17, 2023 14:14
@anuejn anuejn force-pushed the pajowu/download_vtt branch 2 times, most recently from 3fa92e5 to 3eb38c3 Compare April 25, 2023 11:16
anuejn
anuejn approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :).
I would move the button somewhere else in the future but for now at the bottom seems like a fair place to me :)

@pajowu pajowu enabled auto-merge April 26, 2023 00:09
@pajowu pajowu added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit d03c6f1 Apr 26, 2023
@pajowu pajowu deleted the pajowu/download_vtt branch April 26, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuejn anuejn anuejn approved these changes

@phlmn phlmn Awaiting requested review from phlmn

@rroohhh rroohhh Awaiting requested review from rroohhh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pajowu @anuejn