-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual ACK packet support #855
Open
xiaocq2001
wants to merge
7
commits into
bytebeamio:main
Choose a base branch
from
xiaocq2001:chxiao/manual_ack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaavva
reviewed
Apr 30, 2024
Are there any additional comments or feedback? If this solution is acceptable, could you please advise on the steps I can take to expedite the merging process? |
Added some docs about the API usage. Please check. |
Any comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for issue #841 and issue #609.
Note the example of
async_manual_acks_v5
needs PR #854 to make broker re-send publishes.Type of change
New feature (non-breaking change which adds functionality)
get_manual_ack
to return manual ack packet whereset_reason
/set_code
to update reason codeset_reason_string
to set reason stringset_user_properties
to set user propertiesmanual_ack
/try_manual_ack
to send the modified packet (PUBACK/PUBREC) returned byget_manual_ack
Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.