Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to [email protected] #43

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

sunfishcode
Copy link
Member

Update WASI-virt to [email protected]. Several interfaces in wasi-sockets changed, so this updates the virtual-adapter accordingly.

@guybedford
Copy link
Collaborator

I think the virt-deny / "strip virt" functionality also needs to be updated here for the function signature changes. Ideally we should auto-generate all of this from the WITs, but that work hasn't been done yet so for now those all need to be maintained manually.

@sunfishcode
Copy link
Member Author

Yeah, was trying to split out some changes to help isolate a wasm-encoder chage, but split out too much.

@guybedford
Copy link
Collaborator

@sunfishcode I've pushed some more WIT updates here as well as using the WIT bindgen bug fix at bytecodealliance/wit-bindgen#831 that was necessary to get this to build.

The current failure is now that we use an empty world to build up the full virt world (virt-base) but it seems somewhere along the upgrade path, worlds are now being automatically pruned from components, so we likely need to change the strategy in https://github.com/bytecodealliance/WASI-Virt/blob/main/src/lib.rs#L168 where we read the full WIT folder from the binary encoding in the virtual adapter, to ensure that we can definitely find all the worlds that we encoded from the WIT folder instead of them getting automatically pruned in the binary.

@guybedford guybedford changed the title Update to [email protected]. Update to [email protected] Feb 5, 2024
@alexcrichton
Copy link
Member

I've posted sunfishcode#1 as an update to this PR which updates the decoding process for the newly-encoded WIT format.

@guybedford
Copy link
Collaborator

I've updated the PR with @alexcrichton's fix, and can confirm the remaining bugs are now just in the deny and strip virt updates. Will try and push those shortly.

@guybedford guybedford merged commit 4623ba6 into bytecodealliance:main Feb 13, 2024
2 checks passed
sunfishcode added a commit to sunfishcode/WASI-Virt that referenced this pull request Feb 14, 2024
It appears I missed updating all the signatures in virt_deny in bytecodealliance#43, so
this commit updates them.
sunfishcode added a commit that referenced this pull request Feb 14, 2024
It appears I missed updating all the signatures in virt_deny in #43, so
this commit updates them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants