fix: truly respect --allow-all to allow all components
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ArgAction::SetTrue` is not the right action for `allow_xxx` options, as they should default to `None` instead of `Some(false)` when the option itself is not specified. The wrong default value led to the `--allow-all` option not being respected, as the `allow_xxx.unwrap_or(allow_all)` always ignored the `allow_all` value.
|
Amazing, thanks for spotting that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgAction::SetTrueis not the right action forallow_xxxoptions, as they should default toNoneinstead ofSome(false)when the option itself is not specified. The wrong default value led to the--allow-alloption not being respected, as theallow_xxx.unwrap_or(allow_all)always ignored theallow_allvalue.