dep: Optionalize wasm-opt crate dependency
#63
Merged
+51
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/feature-wasm-opt
branch
from
ac15646
to
887f39c
Compare
The `wasm-opt` crate brings in C++ dependencies (binaryen) and it makes the build process more complex and slower (also setting up cross-compilation for C++ is not trivial unlike Rust). Also the DCE process doesn't make much difference if we allow all WASI subsystems. This commit makes the `wasm-opt` crate dependency optional so that crate users can choose whether to use it or not. Also strip the "name" section at walrus module generation time if `debug=false` because it was stripped by `wasm-opt` before.
kateinoigakukun
force-pushed
the
katei/feature-wasm-opt
branch
from
887f39c
to
c1dc925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wasm-optcrate brings in C++ dependencies (binaryen) and it makes the build process more complex and slower (also setting up cross-compilation for C++ is not trivial unlike Rust). Also the DCE process doesn't make much difference if we allow all WASI subsystems.This commit makes the
wasm-optcrate dependency optional so that crate users can choose whether to use it or not.Also strip the "name" section at walrus module generation time if
debug=falsebecause it was stripped bywasm-optbefore.Data point
We use wasi-virt to embed Ruby installation package with
--allow-all:At least for us, more 300 bytes to simplify build is fine.