Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding UPF Machine charm howto #17

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

markbeierl
Copy link
Contributor

Description

Adds a simple howto showing deployment of machine charm with Terraform

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • N/A I have added tests that validate the behaviour of the software
  • N/A I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • N/A I have bumped the version of the library

@markbeierl markbeierl requested a review from a team as a code owner June 6, 2024 14:44
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first pass, I plan on trying this out today

docs/how-to/deploy_sdcore_upf_machine.md Outdated Show resolved Hide resolved
Co-authored-by: Ghislain Bourgeois <[email protected]>
docs/how-to/deploy_sdcore_upf_machine.md Outdated Show resolved Hide resolved

cat << EOF > terraform.tfvars
machine_number = 0
model_name = "user-plane"
Copy link
Contributor

@gatici gatici Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tell user to add config options to match with environment.
As an example:

config = {
core-interface-name = "enp6s0"
access-interface-name = "enp7s0"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
And it's not just about the network interfaces. The rest of the networking params needs to be here as well (unless you're super lucky to be using the addressing matching the defaults :) ).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should probably list most of the settings, even if we just repeat the defaults, this will make it easier to follow and tweak correctly.

@markbeierl markbeierl requested a review from gatici June 10, 2024 15:09
docs/how-to/deploy_sdcore_upf_machine.md Outdated Show resolved Hide resolved
docs/how-to/deploy_sdcore_upf_machine.md Show resolved Hide resolved

- A host with a CPU supporting AVX2 and RDRAND instructions (Intel Haswell, AMD Excavator or equivalent)
- [Juju][Juju] controller bootstrapped to a LXD cluster
- A machine added to the Juju controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add machine to the model, it stays in pending state. Is this normal? So far, I've been only adding machines to models hosted on a separate Juju VM; and then it would go idle state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should go to active idle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, that's probably because I was trying to co-locate Juju and the UPF.
I think the requirements section should state more clearly that we need 2 machines for this how-to - one for Juju and one for UPF.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aggree with Bart. It is better to state that Juju and UPF needs to be located on different machines.

Co-authored-by: Bartlomiej Gmerek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants