Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update mastering tutorial to use Infrastructure as Code #19

Merged
merged 12 commits into from
Jul 3, 2024

Conversation

ghislainbourgeois
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois commented Jun 20, 2024

Description

This PR adds a Terraform module that deploys the required infrastructure to run the mastering tutorial. At the same time, it simplifies the setup by using LXD directly and using advanced features, like the automatic DNS on managed bridge networks.

The tutorial itself is simplified a lot and should be easier to run for users, with less chance for errors.

The Terraform module could also be reused for testing different scenarios.

Known issues:

  • There is a race condition adding the SSH keys to the machines related to cloud-init execution. Retrying the terraform apply seems to work consistently.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@ghislainbourgeois ghislainbourgeois marked this pull request as ready for review June 27, 2024 22:45
@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner June 27, 2024 22:45
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great job.

docs/tutorials/mastering.md Outdated Show resolved Hide resolved
@ghislainbourgeois ghislainbourgeois merged commit bcc39b2 into main Jul 3, 2024
8 checks passed
@ghislainbourgeois ghislainbourgeois deleted the feat-iac branch July 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants