networkd: move KeepConfiguration= into [Network] section

Fixup for #424
canonical · Dec 12, 2023 · 4f7862a · 4f7862a
1 parent 92759d4
commit 4f7862a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/networkd.c b/src/networkd.c
@@ -844,6 +844,9 @@ netplan_netdef_write_network_file(
     if (def->type >= NETPLAN_DEF_TYPE_VIRTUAL || def->ignore_carrier)
         g_string_append(network, "ConfigureWithoutCarrier=yes\n");
 
+    if (def->critical)
+        g_string_append_printf(network, "KeepConfiguration=true\n");
+
     if (def->bridge && def->backend != NETPLAN_BACKEND_OVS) {
         g_string_append_printf(network, "Bridge=%s\n", def->bridge);
 
@@ -916,14 +919,11 @@ netplan_netdef_write_network_file(
         }
     }
 
-    if (def->dhcp4 || def->dhcp6 || def->critical) {
+    if (def->dhcp4 || def->dhcp6) {
         /* NetworkManager compatible route metrics */
         g_string_append(network, "\n[DHCP]\n");
     }
 
-    if (def->critical)
-        g_string_append_printf(network, "KeepConfiguration=true\n");
-
     if (def->dhcp4 || def->dhcp6) {
         if (def->dhcp_identifier)
             g_string_append_printf(network, "ClientIdentifier=%s\n", def->dhcp_identifier);

diff --git a/tests/generator/test_common.py b/tests/generator/test_common.py
@@ -480,8 +480,6 @@ def test_dhcp_critical_true(self):
 
 [Network]
 LinkLocalAddressing=ipv6
-
-[DHCP]
 KeepConfiguration=true
 '''})