Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pciid match support #375

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fatihusta
Copy link

@fatihusta fatihusta commented Jul 6, 2023

Description

Netplan doesn't match mac address of ethernet when using bond. So member ethernet doesn't up.

This PR fixes ethernet up problem, but still prints warning message(below).

I try to add PCI ID match support for better renaming to the ethernet.

[]
Cannot find unique matching interface for enp152s0f0np0
[]
Cannot find unique matching interface for eno12399np0
[]
Cannot find unique matching interface for enp152s0f1np1
[]
Cannot find unique matching interface for eno12409np1

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

Also may fixes this issue: https://bugs.launchpad.net/netplan/+bug/1608447

@slyon slyon added the schema change This PR includes a change to netplan's YAML schema, which needs sign-off label Jul 10, 2023
@slyon
Copy link
Collaborator

slyon commented Aug 16, 2023

Sorry, this is taking much longer than anticipated. I like the idea of having pciid matching capabilities. But it touches core components of Netplan and I need to find enough time to do a proper review on this.

@slyon slyon added the community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. schema change This PR includes a change to netplan's YAML schema, which needs sign-off
Projects
None yet
2 participants