Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): added hover and active styles #16523

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

soumyaraju
Copy link

@soumyaraju soumyaraju commented May 21, 2024

Part of #15961

It adds the active and hover states to the line and contained scrollable icon buttons and also fixes the Background missing on left scroll button for line tabs.

Rest of the issues mentioned are handled in a different PR #16522

Changelog

New

Screenshot 2024-05-21 at 7 51 55 PM Screenshot 2024-05-21 at 7 50 25 PM

Testing / Reviewing

Copy link
Contributor

github-actions bot commented May 21, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@soumyaraju
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e8c6e4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/664cac3f9e4c5f0008268744
😎 Deploy Preview https://deploy-preview-16523--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6e8c6e4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/664cac3fc7b1230008bf62cb
😎 Deploy Preview https://deploy-preview-16523--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soumyaraju soumyaraju marked this pull request as ready for review May 21, 2024 14:25
@soumyaraju soumyaraju requested a review from a team as a code owner May 21, 2024 14:25
Copy link

netlify bot commented May 21, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a2ed999
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667067a268186400095ca503
😎 Deploy Preview https://deploy-preview-16523--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a2ed999
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667067a22591410008e9baf9
😎 Deploy Preview https://deploy-preview-16523--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soumyaraju
Copy link
Author

recheck

@soumyaraju
Copy link
Author

recheck

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover states look good. I see you added the active styling but for some reason the active styling is not applied when clicking down and holding the mouse down. You can see here I toggle the active styling on and it's correct, but when I click and hold to scroll it doesn't change from the hover styling:

CleanShot.2024-06-17.at.11.47.33.mp4

@tay1orjones
Copy link
Member

The contained tabs have the same issue. There's something odd going on with the gradient. I'm not sure if it's related to your changes or not, but holding down the right arrow a second time after it's already scrolled all the way to the right makes it go backwards the other way.

CleanShot.2024-06-17.at.11.51.01.mp4

You might consider moving these changes into #16522 (review) or moving those changes into this PR so we can make sure it's fully correct with all these changes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants