Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16624 allowcustomvalue not fire onchange event #16743

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

preetibansalui
Copy link
Contributor

Closes #16624

allowCustomValue doesn't fire onChange event

Testing / Reviewing

  1. Pass allowCustomValue as true to combobox
  2. Enter some random value in input and press enter
  3. It should fire the onChange event now.

@preetibansalui preetibansalui requested a review from a team as a code owner June 12, 2024 12:27
@preetibansalui preetibansalui changed the title 16624 allowcustomvalue no fire onchange event 16624 allowcustomvalue not fire onchange event Jun 12, 2024
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b749578
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667527bfe9ce9b0008b124b0
😎 Deploy Preview https://deploy-preview-16743--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b749578
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667527bfcadc34000821458d
😎 Deploy Preview https://deploy-preview-16743--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Gururajj77 Gururajj77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 🔥

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Works great !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ComboBox - allowCustomValue no longer fires change event with custom value
4 participants