Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 minimum money amount #144

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

julienbrs
Copy link
Collaborator

@julienbrs julienbrs commented Oct 2, 2024

closes #137
Either we make sure the minimal amount to pay is > 0 (to avoid any rounding errors that could lead to buy CC with $0), or we put an arbitrary min amount to buy (for example 1 cents)

@julienbrs julienbrs requested a review from tekkac October 2, 2024 15:23
@julienbrs julienbrs self-assigned this Oct 2, 2024
Copy link
Contributor

@tekkac tekkac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tekkac tekkac merged commit 54c3f69 into carbonable-labs:main Oct 3, 2024
2 checks passed
@julienbrs julienbrs deleted the 137-min-buying-amount branch October 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amount money management at minting
2 participants