Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container] install vim for adding transaction messages #1641

Conversation

TrevorBenson
Copy link
Collaborator

Description

Installs vi into the container.

Where should the reviewer start?

files/docker/node/dockerfile_bin line 35

Motivation and context

To allow cntools to add messages to transactions inside the container.

Which issue it fixes?

Closes #1640

How has this been tested?

  1. Installed vim package [docker|podman] exec -it -u root <container_name> bash -c 'apt-get update ; apt-get install -y vim'
  2. Repeat steps To Reproduce in Container lacks support for adding messages to transactions via cntools #1640

Copy link
Contributor

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but as you know docker isn't my think so I'll let others chime in as well :)

@rdlrt rdlrt merged commit b9cafd3 into cardano-community:alpha May 7, 2023
1 check passed
@TrevorBenson TrevorBenson deleted the container-include-vi-for-tx-messages branch May 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container lacks support for adding messages to transactions via cntools
3 participants