feat: add keyboard shortcuts for Editor actions #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <action id="CodeGPT.TriggerEditorPopup" | ||
| class="ee.carlrobert.codegpt.actions.editor.ShowEditorActionGroupAction" | ||
| text="Show CodeGPT Actions"> | ||
| <keyboard-shortcut first-keystroke="ctrl shift alt m" keymap="$default"/> |
There was a problem hiding this comment.
Can we add the same shortcut for mac os x as well?
https://github.com/carlrobertoh/CodeGPT/blob/platform/2024.1/src/main/resources/META-INF/plugin.xml#L77
There was a problem hiding this comment.
Sorry, as a Linux and Windows User I always forget about that "other" keyboard 😆
Aren't they missing for the toggle Code Completions Action too?
There was a problem hiding this comment.
Please ignore my last comment, sorry. The ctrl shift alt m combination is already valid on mac as shift option meta m. No changes needed.
There was a problem hiding this comment.
I removed the additional keyboard-shortcuts again
PhilKes
force-pushed
the
actions-shortcuts
branch
from
963120c
to
092b6a7
Compare
|
thank you very much for your hard work @PhilKes |
carlrobertoh
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #314
Adds Action to show CodeGPT Actions popup with keyboard shortcut:
All Actions are assigned an alpha-numeric letter for seamless keyboard controls.
I didn't really know how to define the best default shortcut, so I sticked with the
CTRL+SHIFT+ALTcombo plus "M" (maybe "M" for "Menu"?), that doesn't seem to be used by anything too important: