Add quality param #9
Conversation
|
This addressed #7 |
|
Hey, thanks for your interest in this! Would you be able to add some tests for this new functionality and update the readme, please, so that others may contribute with confidence in the future? |
| .check((args) => { | ||
| if (args.quality != null) { | ||
| if (args.quality <= 0 || args.quality > 1) { | ||
| throw 'quality must be a number between 0 and 1'; |
There was a problem hiding this comment.
All values being thrown should be errors. This might even be a time where it's appropriate to use RangeError!
| throw 'quality must be a number between 0 and 1'; | |
| throw new RangeError('quality must be a number between 0 and 1'); |
| .option('quality', { | ||
| alias: 'q', | ||
| describe: 'The jpeg compression quality, between 0 and 1', | ||
| default: '1', |
There was a problem hiding this comment.
I am not entirely sure whether yargs typecasts the default value, but it will definitely typecast the parsed values. Since this is a number, it would be best that the default also be a number rather than a string.
| default: '1', | |
| default: 1, |
| const buffer = input === '-' ? | ||
| await readStdin() : | ||
| await promisify(fs.readFile)(path.resolve('.', input)); | ||
|
|
||
| const results = await convert.all({ buffer, format: FORMAT[format], quality: 1 }); | ||
| const results = await convert.all({ buffer, format: FORMAT[format], quality: quality }); |
There was a problem hiding this comment.
| const results = await convert.all({ buffer, format: FORMAT[format], quality: quality }); | |
| const results = await convert.all({ buffer, format: FORMAT[format], quality }); |
This is a good note for me that I actually forgot to add this rule to eslint. I will do that separately.
Was converting a bunch of files and was getting 11MB jpgs from 3MB HEICs. Turning quality down to 85% resulted in similarly-sized files with quality good enough for my use. Perhaps this will be useful to someone else.