Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a function to censor passwords and updated HACKING.txt #130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samghelms
Copy link

@samghelms samghelms commented Nov 5, 2018

I love this package, but it keeps printing out my password in cleartext when I use it with an odbc driver. For example:

input cell:

%%sql
select * from csn_survey.tblSurvey limit 3

output:

* vertica+pyodbc:///?odbc_connect=DRIVER=/opt/vertica/lib64/libverticaodbc.so;SERVER=myvertica.com;DATABASE=mydb;PORT=myport;UID=samghelms;PWD=mypassword

<table output>

This PR adds a censor_passwords function that attempts to find any password parameters in the URL string and censor them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant