-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for the issue 357 #241
Draft
kewaljani
wants to merge
718
commits into
catherinedevlin:master
Choose a base branch
from
ploomber:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kewaljani please close this PR. |
* Added bar and pie charts * Added tests * Format * Added support for orient in bar graph * test and formatting * Added doc * changelog * Fix api doc * Fix * Removed facet * Fix * Fix * Added --show_number argument * Modified doc * Updated tests * Fixed error type Removed print statement * typo * Changed arg name * Fix error type * Added version admonition * Added matplotlib test * Format * Fix tests Fix .gitignore * Format * Fix tests * Fix tests * Added support for NULLs * Fix * Lint * Updated imgs * Fix doc * Minor * lint * Added print statement * Added null test * Lint * Fix * Fix tests * Format
* add in live * trigger rebuild * trigger rebuild * fix syntax * add password * only executed by workflow_call * comment out explicitl kv * clean up
* --with deprecation in CTE CTE depr Warning msg, sqlglot Lint tests warn test conditions for extract Empty commit removed with test exception handling Fixed tests Lint typo error test condition for typo suggestions plot changes merge conflict fix test Fix test fix test tests list of with sqlcmd delete sqlcmd tests rebase Fixes fixed test fixes removed test non-existent tbl Test fix fix typo test fix typo test space removed delete snippet test test fix Docs docs toc changelog modified args modified versionchanged added message changed tests sqlcmd added deprecation warning changed tests depr warning removed if exists debug prints added clean_conns rebase test fix rebase issues revert error msg test for snippet utils telemetry removed Minor changes Moved string refactor plot tests plot_typo Renamed test file Removed line test fix test fix Review comments added issue numbers rebase lint * added to bar, pie" * Empty commit
* fixed merge conflicts and added atextit: ready for review * added verbose argument to close_all() and atexit.register()
* trinodb integration guide first review * fix linting errors in PR * linting error fixed (checked locally) * jupysql env config then ran pkgmt to fix linting * run docker locally and update conf.py so readthedocs wont run docker * fix readdocs: added trinodb to toc * disable version check for jupysql project * echo method for vcheck disable --------- Co-authored-by: Eduardo Blancas <[email protected]>
* removing psutil and jupyterlab check function * adding jupysql-plugin in setup * adding jupysql-plugin formatted * Update CHANGELOG.md --------- Co-authored-by: Eduardo Blancas <[email protected]>
* Validating CLI arguments * Validating CLI arguments * remove rec_arguments array and add tests for line magic and cell magic * Update docs to use --alias * Remove pinned pydata version * Validating CLI arguments update * Update document to use --alias * Update PR * Update intro.md --------- Co-authored-by: Eduardo Blancas <[email protected]>
cgangelog review comments
lint screenshots added images Review comments spyder screenshot pycharm added
* histogram nulls support' * histogram nulls support with changelog' * histogram support with new test * test updated * updating changelog * updated magic-plot.md for histogram * updated magic-plot.md for histogram nulls * removing test notebook * updated facet-wrapper to support nulls * updated facet-wrapper to support nulls with test * spell-check * spell-check lint check * changed filter logic * changed filter logic removed local scripts * yield ip added * removed intermediate table for nulls and function-name-changes * removed intermediate table for nulls and function-name-changes * comments restructuring * comments restructuring and renaming * filter_aggregate now accepts multiple arguments, ggplot has a test with dummy data
* Update: comments * Update: comments
* 20x bottom padding * 20x bottom padding with changelog * 20x bottom padding remove scripts
* Remove fuzzy matching when searching for the [tool.jupysql.SqlMagic] section * Remove default parameter from `get_nested` and add docstring * Revise to look for case in jupysql and close_match for SqlMagic * Fix line lengths for linter
Empty
* updates dependencies * update changelog * ci * fix test * fix
* removed clickhouse * removed clickhouse from nox * Empty
It was missing the self argument. But it also isn't needed at all.
…#1016) * fix: query config value must be coniverted to dict to be usable by URL.create() * lint * changelog * changelog * docstring * lint * typos * fix: unpin duckdb version * fix: snippet tests * fix: json tests * fix: remove test * fix: mysql integration tests * fix: json tests * fix: rename to parse_config_section * fix: failing oracle integration test 'ip_with_oracle' * fix: broken link to CI db integration badge * doc: add example config with query parameters * fix: revert overzealous rebases * ci --------- Co-authored-by: Van Leuven Wim (100) <[email protected]> Co-authored-by: Eduardo Blancas <[email protected]>
* Remove sqlalchemy upper bound * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the issue 357