update for Jupyter 4 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get rid of the traitlets warnings Signed-off-by: Mark McCahill <[email protected]>
Signed-off-by: Mark McCahill <[email protected]>
For student use, default the limits for rows returned (100000) and rows displayed (1000) to sizes that will not crash their web browser or pound the SQL server. You can still reset the limits if you want, but this raises the barrier to shooting yourself in the foot. Signed-off-by: Mark McCahill <[email protected]>
|
poke anyone? |
|
This PR seems to be doing 3 somewhat unrelated things... |
|
My huge apologies - I had GitHub notifications misconfigured, and 4 (!) different people submitted this same enhancement. I merged #50, since it included the test file. I'll investigate the other changes in your PR as soon as I can. Thanks so much! |
|
Why is this not getting merged? |
|
Hi Catherine, your extension is really great. Thank you! Please see ifyou can find a moment to apply this PR. The warning doesn't look very nice in the notebook |
Signed-off-by: Mark McCahill <[email protected]>
Signed-off-by: Mark McCahill <[email protected]>
|
I was wondering how to install this particular branch. Will I need to compile it from source myself? Or can I simply run setup.py? |
|
@zebralight, to install this version: $ pip install git+git://github.com/mccahill/ipython-sql.git |
kavisek
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under iPython4 (Jupyter) there are warnings about deprecated calls when calling load_ext sql
This commit fixes that, and also gets around the ascii character set problems in reading in the README and NEWS files when compiling.
Signed-off-by: Mark McCahill [email protected]