Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set minimum CDK version to a 2.105.0 for Runtime.PROVIDED_AL2023 #497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: set minimum CDK version to a 2.105.0 for Runtime.PROVIDED_AL2023 #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions .projen/deps.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .projen/tasks.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const project = new CdklabsConstructLibrary({
private: false,
author: 'wchaws',
authorAddress: 'https://aws.amazon.com',
cdkVersion: '2.0.0',
cdkVersion: '2.105.0',
cdkVersionPinning: false,
defaultReleaseBranch: 'main',
majorVersion: 3,
Expand All @@ -26,8 +26,6 @@ const project = new CdklabsConstructLibrary({
'hpagent',
],
deps: [
'aws-cdk-lib@^2.0.0',
'constructs@^10.0.5',
Copy link
Author

@blimmer blimmer Jan 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to specify this. It's controlled by the upstream projen config and the peerDependencies it produces. In fact, this caused problems for me because yarn used a newer aws-cdk-lib version than what's specified in your peer deps.

'got',
'hpagent',
], /* Runtime dependencies of this module. */
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

74 changes: 50 additions & 24 deletions yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading