Skip to content

Commit

Permalink
Test - Renable JavascriptBinding IntegrationTestFacts
Browse files Browse the repository at this point in the history
- Now that https://bitbucket.org/chromiumembedded/cef/issues/3260/support-reconnect-of-mojo-frame-channel has been resovled see if the
tests will run on appveyor reliable
- Use a new RequestContext to isolate the unreliable test cases.

Issue #3867
  • Loading branch information
amaitland committed Sep 8, 2022
1 parent 7f00aac commit 3899f32
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions CefSharp.Test/JavascriptBinding/IntegrationTestFacts.cs
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ public async Task LoadJavaScriptBindingQunitTestsSuccessfulCompletion()
}
#else

// Issue https://github.com/cefsharp/CefSharp/issues/3867
[SkipIfRunOnAppVeyorFact]
[Fact]
public async Task LoadJavaScriptBindingQunitTestsSuccessfulCompletion()
{
using (var browser = new ChromiumWebBrowser(CefExample.BindingTestUrl, automaticallyCreateBrowser: false))
var requestContext = new RequestContext();
requestContext.RegisterSchemeHandlerFactory("https", CefExample.ExampleDomain, new CefSharpSchemeHandlerFactory());

using (var browser = new ChromiumWebBrowser(CefExample.BindingTestUrl, requestContext: requestContext, automaticallyCreateBrowser: false))
{
//TODO: Extract this into some sort of helper setup method
var bindingOptions = BindingOptions.DefaultBinder;
Expand Down Expand Up @@ -160,8 +162,7 @@ public async Task LoadJavaScriptBindingAsyncTaskQunitTestsSuccessfulCompletion()
}
}

[SkipIfRunOnAppVeyorFact()]
//Skipping Issue https://github.com/cefsharp/CefSharp/issues/3867
[Fact]
public async Task LoadLegacyJavaScriptBindingQunitTestsSuccessfulCompletion()
{
var requestContext = new RequestContext();
Expand Down

0 comments on commit 3899f32

Please sign in to comment.