DatabaseScheduler: Reload config when Cron or Interval was changed #352
Conversation
… Cron or Interval
ebertti
changed the title
|
👀 |
|
any test and release notes for the proposed changes? |
| @@ -182,6 +184,8 @@ class PeriodicTasks(models.Model): | |||
| ident = models.SmallIntegerField(default=1, primary_key=True, unique=True) | |||
| last_update = models.DateTimeField(null=False) | |||
|
|
|||
| no_changes = False | |||
There was a problem hiding this comment.
What is the purpose of this line here? Maybe it should be moved to IntervalSchedule?
There was a problem hiding this comment.
I try to re-use the same trigger for PeriodicTask when IntervalSchedule or CrontabSchedule has some change.
So, without this, you need to restart de celery beat to reload configuration of CrontabSchedule or IntervalSchedule, or you need to trigger some modification on PeriodicTask to reload configuration.
There was a problem hiding this comment.
That seems reasonable.
But this line is defined on PeriodicTasks class. I don't think it is needed here, since the signal is not connected with sender=PeriodicTasks. Meanwhile, IntervalSchedule doesn't have no_changes.
Using the same signal when PeriodicTask was changed on Django ORM