Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navajo: Brings envelope::sync::Envelope in line with Envelope #71

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

chanced
Copy link
Owner

@chanced chanced commented Apr 25, 2023

currently, the async `Envelope trait's associated error types are:

pub trait Envelope {
    type EncryptError: core::fmt::Display + core::fmt::Debug + Send + Sync;
    type DecryptError: core::fmt::Display + core::fmt::Debug + Send + Sync;
    // ...
}

while the sync version is:

pub trait Envelope {
    type EncryptError: super::Error + Send + Sync;
    type DecryptError: super::Error + Send + Sync;
    // ...
}

This brnigs both in line by replacing super::Error with Display + Debug

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (456cd2e) 73.34% compared to head (cf8bc54) 73.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   73.34%   73.31%   -0.03%     
==========================================
  Files          93       93              
  Lines       10916    10916              
==========================================
- Hits         8006     8003       -3     
- Misses       2910     2913       +3     
Impacted Files Coverage Δ
navajo/src/envelope.rs 75.16% <ø> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chanced chanced merged commit b399e6f into main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants